Reserving comments about coding style, may I recommend moving the
invocation of AttachEvent.fire() in Widget from the onLoad() and
onUnload() methods to the onAttach() and onDetach methods
respectively?

Reasoning? Historically, the onLoad() and onUnload() methods have been
default empty implementations. I for one have assumed the methods to
be like abstract "stubs" and generally do not invoke super.onLoad() or
super.onUnload() when overriding the method.

It might help improve the reliability of having the AttachEvent fire
if the invocation is moved as I suggest. Or even better, move the
invocation to a part of the code not likely to be overriden by
subclasses.

Thoughts?

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to