On 2010/10/20 20:06:42, conroy wrote:
I'm glad you mention this: In the latest version of the patch I'm
nuking
Makefile.mac (amongst other cruft) since unused bits like this laying
around
just cause confusion.
XP_MACOSX is set higher up in the Makefile on the OS==mac check. I set XP_UNIX there so that linux and mac can share it.
On Wed, Oct 20, 2010 at 4:00 PM, <mailto:[email protected]> wrote:
> On 2010/10/20 19:44:12, conroy wrote: > >> http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001 >> File plugins/npapi/Makefile (right): >> > >
http://gwt-code-reviews.appspot.com/1036801/diff/6001/7001#newcode47
>> plugins/npapi/Makefile:47: CFLAGS += -DBROWSER_NPAPI -DXP_UNIX >> > -fshort-wchar > >> On 2010/10/20 19:31:06, fabiomfv wrote: >> > out of curiosity, why are we defining XP_UNIX for a presumably
mac
>> > build? > > Mac is a variant of Unix. The other npapi plugin code I looked at
all
>> > defined > >> XP_UNIX for both linux and mac builds. >> > > I guess want I really meant was why we don't need XP_MACOSX
explicitly
> and only XP_UNIX? for instance, looking at makefile.mac it seems
they
> refer to both. > > > > http://gwt-code-reviews.appspot.com/1036801/show >
Sorry, somehow I did not see the XP_MACOSX def up above the script (I guess I am still getting used to the rietveld review ui). LGTM2 http://gwt-code-reviews.appspot.com/1036801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
