Reviewers: unnur_google.com,

Description:
Make the following method public in StackTraceDeobfuscator, for reuse by
user server side code:
StackTraceElement resymbolize(StackTraceElement ste, String strongName)

Review by: [email protected]

Please review this at http://gwt-code-reviews.appspot.com/1040801/show

Affected files:
  M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java


Index: user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
===================================================================
--- user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java (revision 9129) +++ user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java (working copy)
@@ -60,6 +60,25 @@
       lr.setThrown(deobfuscateThrowable(lr.getThrown(), strongName));
     }
     return lr;
+  }
+
+  public StackTraceElement resymbolize(StackTraceElement ste,
+      String strongName) {
+    SymbolMap map = loadSymbolMap(strongName);
+    String symbolData = map == null ? null : map.get(ste.getMethodName());
+
+    if (symbolData != null) {
+      // jsniIdent, className, memberName, sourceUri, sourceLine
+      String[] parts = symbolData.split(",");
+      if (parts.length == 5) {
+        String[] ref = parse(
+            parts[0].substring(0, parts[0].lastIndexOf(')') + 1));
+        return new StackTraceElement(
+            ref[0], ref[1], ste.getFileName(), ste.getLineNumber());
+      }
+    }
+    // If anything goes wrong, just return the unobfuscated element
+    return ste;
   }

   public void setSymbolMapsDirectory(String dir) {
@@ -132,23 +151,4 @@
     String[] toReturn = new String[] {className, memberName};
     return toReturn;
   }
-
-  private StackTraceElement resymbolize(StackTraceElement ste,
-      String strongName) {
-    SymbolMap map = loadSymbolMap(strongName);
-    String symbolData = map == null ? null : map.get(ste.getMethodName());
-
-    if (symbolData != null) {
-      // jsniIdent, className, memberName, sourceUri, sourceLine
-      String[] parts = symbolData.split(",");
-      if (parts.length == 5) {
-        String[] ref = parse(
-            parts[0].substring(0, parts[0].lastIndexOf(')') + 1));
-        return new StackTraceElement(
-            ref[0], ref[1], ste.getFileName(), ste.getLineNumber());
-      }
-    }
-    // If anything goes wrong, just return the unobfuscated element
-    return ste;
-  }
 }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to