LGTM other than the validation sample.

http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002
File samples/validation/build.xml (right):

http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002#newcode23
samples/validation/build.xml:23: <include
name="javax/validation/validation-api-1.0.0.GA-sources.jar" />
Shouldn't this use gwt-servlet-deps.jar instead?

http://gwt-code-reviews.appspot.com/1047802/diff/3001/4002#newcode25
samples/validation/build.xml:25: <include
name="hibernate/validator/hibernate-validator-4.1.0.Final-sources.jar"
/>
Why do the sources need to be included?

http://gwt-code-reviews.appspot.com/1047802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to