Revision: 9133
Author: [email protected]
Date: Fri Oct 22 07:37:38 2010
Log: Fix issue 5462 where DynaTableRf explodes when favoriting a new person.
This fix hides the favorite checkbox by default, and shows it if the person
has been persisted. This is a pretty dirty hack, so please review it to
make sure it's not too dirty. The correct way to fix this issue would be to
re-work DynaTableRf so that the favorite boolean is a property on the
person, but this is a workaround until that can be done.
Review at http://gwt-code-reviews.appspot.com/1043802
http://code.google.com/p/google-web-toolkit/source/detail?r=9133
Modified:
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java
=======================================
---
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java
Thu Oct 14 08:15:26 2010
+++
/trunk/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/PersonEditorWorkflow.java
Fri Oct 22 07:37:38 2010
@@ -97,6 +97,7 @@
}
}
}, KeyUpEvent.getType());
+ this.favorite.setVisible(false);
}
/**
@@ -156,8 +157,9 @@
private void edit(RequestContext requestContext) {
editorDriver = GWT.create(Driver.class);
editorDriver.initialize(requestFactory, personEditor);
-
+
if (requestContext == null) {
+ this.favorite.setVisible(true);
fetchAndEdit();
return;
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
