Response to previous comments; not a review of the updated patch.
http://gwt-code-reviews.appspot.com/1045801/diff/11001/12003 File dev/core/src/com/google/gwt/core/ext/linker/PrecompilationMetricsArtifact.java (right): http://gwt-code-reviews.appspot.com/1045801/diff/11001/12003#newcode40 dev/core/src/com/google/gwt/core/ext/linker/PrecompilationMetricsArtifact.java:40: this.permutationId = permutationId; Based on the call sites, I think this is permutation base. Sharded precompiles can handle more than 1 permutation per precompile shard. http://gwt-code-reviews.appspot.com/1045801/diff/11001/12004 File dev/core/src/com/google/gwt/core/linker/CompilerMetricsLinker.java (right): http://gwt-code-reviews.appspot.com/1045801/diff/11001/12004#newcode43 dev/core/src/com/google/gwt/core/linker/CompilerMetricsLinker.java:43: @LinkerOrder(Order.POST) I think it doesn't touch <pre> stuff unless it recognizes it as Java code, in which case there's an option to format the embedded code. http://gwt-code-reviews.appspot.com/1045801/diff/11001/12012 File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/1045801/diff/11001/12012#newcode477 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:477: PrecompilationMetricsArtifact precompilationMetrics) See comment below. http://gwt-code-reviews.appspot.com/1045801/diff/11001/12012#newcode637 dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:637: precompilationMetrics.setAstTypes(result.getReferencedJavaClasses()); Sorry, the point I should have stated more clearly is that you actually have the AST already, in scope, in "jprogram". So there's really no reason to loop this through UnifiedAst at all, you can just collect the referenced classes inline. http://gwt-code-reviews.appspot.com/1045801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
