http://gwt-code-reviews.appspot.com/1060801/diff/10001/11003
File
user/src/com/google/gwt/experimental/geolocation/impl/GeolocationImpl.java
(right):

http://gwt-code-reviews.appspot.com/1060801/diff/10001/11003#newcode34
user/src/com/google/gwt/experimental/geolocation/impl/GeolocationImpl.java:34:
return isSupported() ? new GeolocationImpl() : null;
what purpose do multiple instances serve here? there is only one
wnd.navigator.geolocation, why do we need multiple objects to wrap one
object? Unless I'm missing something, it looks like these could all be
static dispatched.

http://gwt-code-reviews.appspot.com/1060801/diff/10001/11003#newcode98
user/src/com/google/gwt/experimental/geolocation/impl/GeolocationImpl.java:98:
@com.google.gwt.experimental.geolocation.impl.GeolocationImpl::success(Lcom/google/gwt/experimental/geolocation/Geolocation$Handler;DDDDDDDZZZZD)(
my JNI-JSNI-fu fails me here: ';DDDDDDDZZZZD'????

http://gwt-code-reviews.appspot.com/1060801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to