I believe it's always been up to the app developer to choose to install AuthenticationFailureHandler or not, in parallel with their choice to use our auth scheme or not.
Having any special case handling for Response.SC_UNAUTHORIZED in DRT seems wrong to me. Making it fail silently like it used to seems just as wrong as a hard coded message. Let's get back to the Roo app. As things stand with DRT right now, or if we delete the Response.SC_UNAUTHORIZED and make it just another unexpected error, is there anything graceful that apps can do? If AuthenticationFailureHandler wanted to do something more graceful than flush the app, say present a reconnect dialog like Wave does, could it? I wonder if we should be extending RequestEvent to allow its receivers to provider a particular ServerFailure instance? That would allow them to set up their own base Receiver class with special case handling of such a failure. Or set their uncaught exception handler to look for a specific message string in the RuntimeException thrown by Receiver.onFailure(ServerFailure). On 2010/10/28 23:08:13, amitmanjhi wrote:
Perhaps for non-roo apps, there could be an alternative AuthenticationFailureHandler which simply displays a pop-up "user not
logged
in".
On Thu, Oct 28, 2010 at 3:49 PM, BobV <mailto:[email protected]> wrote:
> On Thu, Oct 28, 2010 at 6:26 PM, Unnur Gretarsdottir
<mailto:[email protected]>
> wrote: > > Bob - why is the event listener not installed by default in non
roo apps?
> I > > think it was when I originally added this code (although it has
been a
> > while)
> > There is no good default behavior in this case; authentication
almost
> seems to define the phrase "site-specific." The implementation of > AuthenticationFailureHandler makes assumptions about the serving > environment, namely that the "login" and "userId" headers will be > defined. If the login header is undefined, Location.replace() is > called with a null value. > > -- > Bob Vawter > Google Web Toolkit Team >
http://gwt-code-reviews.appspot.com/1061801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
