Failed to deliver probably because I didn't join this group. Sending again.
---------- Forwarded message ---------- From: <[email protected]> Date: Sat, Oct 30, 2010 at 11:10 AM Subject: Fix AbstractDataTable.getValueTimeOfDay() to handle null (issue1067801) To: [email protected] Cc: [email protected], [email protected] Reviewers: zundel, Description: The old test code looked like a copy&paste from getValueString(), which is why it's not failing. Please review this at http://gwt-code-reviews.appspot.com/1067801/show Affected files: visualization/visualization/src/com/google/gwt/visualization/client/AbstractDataTable.java visualization/visualization/test/com/google/gwt/visualization/client/DataTableTest.java Index: visualization/visualization/test/com/google/gwt/visualization/client/DataTableTest.java =================================================================== --- visualization/visualization/test/com/google/gwt/visualization/client/DataTableTest.java (revision 1844) +++ visualization/visualization/test/com/google/gwt/visualization/client/DataTableTest.java (working copy) @@ -135,7 +135,7 @@ fail(e.getMessage()); } data.setValue(0, 0, (TimeOfDay) null); - assertNull(data.getValueString(0, 0)); + assertNull(data.getValueTimeOfDay(0, 0)); assertTrue(data.isValueNull(0, 0)); } }); Index: visualization/visualization/src/com/google/gwt/visualization/client/AbstractDataTable.java =================================================================== --- visualization/visualization/src/com/google/gwt/visualization/client/AbstractDataTable.java (revision 1844) +++ visualization/visualization/src/com/google/gwt/visualization/client/AbstractDataTable.java (working copy) @@ -133,8 +133,11 @@ }-*/; public final TimeOfDay getValueTimeOfDay(int rowIndex, int columnIndex) { + JsArrayInteger jsArray = getValueArrayInteger(rowIndex, columnIndex); + if (jsArray.length() == 0) { + return null; + } TimeOfDay result = new TimeOfDay(); - JsArrayInteger jsArray = getValueArrayInteger(rowIndex, columnIndex); try { result.setHour(jsArray.get(0)); result.setMinute(jsArray.get(1)); -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
