[gwt-contrib] Restores re-working @UiField and Widget replacement to use DOM walking rather (issue1073801)

Tue, 02 Nov 2010 10:01:38 -0700 

Reviewers: sbrubaker, tstains_google.com,

Description:
Restores re-working @UiField and Widget replacement to use DOM walking
rather
then IDs.

Microbenchmarks show ~10% speedup in Firefox/Webkit browsers.  AdWords
saw little change on Firefox and potential 3% improvement in startup
time on chrome.

Some additional constraints on UiBinders:
+ To simplify handling of paragraph, we disallow block-level fields and
inside
of <p> elements.
+ TD tags MUST be withing a TR to simplify DOM walking.


Please review this at http://gwt-code-reviews.appspot.com/1073801/show

Affected files:
  M user/src/com/google/gwt/dom/client/DOMImpl.java
  M user/src/com/google/gwt/dom/client/DOMImplIE6.java
  M user/src/com/google/gwt/dom/client/Node.java
  M user/src/com/google/gwt/uibinder/client/UiBinderUtil.java
  M user/src/com/google/gwt/uibinder/elementparsers/CustomButtonParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/DomElementParser.java
  user/src/com/google/gwt/uibinder/elementparsers/FieldInterpreter.java
  M user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/HTMLPanelParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/HasHTMLParser.java
M user/src/com/google/gwt/uibinder/elementparsers/HtmlMessageInterpreter.java M user/src/com/google/gwt/uibinder/elementparsers/HtmlPlaceholderInterpreter.java M user/src/com/google/gwt/uibinder/elementparsers/StackLayoutPanelParser.java M user/src/com/google/gwt/uibinder/elementparsers/TabLayoutPanelParser.java 
  M user/src/com/google/gwt/uibinder/elementparsers/TabPanelParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/WidgetInterpreter.java
M user/src/com/google/gwt/uibinder/elementparsers/WidgetPlaceholderInterpreter.java 
  A user/src/com/google/gwt/uibinder/rebind/DomCursor.java
  M user/src/com/google/gwt/uibinder/rebind/GetInnerHtmlVisitor.java
  M user/src/com/google/gwt/uibinder/rebind/Statements.java
  A user/src/com/google/gwt/uibinder/rebind/TableNormalizer.java
  A user/src/com/google/gwt/uibinder/rebind/TableNormalizerTest.java
  M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
  M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
  M user/src/com/google/gwt/uibinder/rebind/XMLElement.java
  M user/test/com/google/gwt/uibinder/UiBinderJreSuite.java
  M user/test/com/google/gwt/uibinder/client/UiBinderUtilTest.java
  M user/test/com/google/gwt/uibinder/elementparsers/MockUiBinderWriter.java
  M user/test/com/google/gwt/uibinder/rebind/DesignTimeUtilsTest.java
  A user/test/com/google/gwt/uibinder/rebind/DomCursorTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to