This probably needs a README file to help users run the tests.

I was not able to generate a gwt-x.y.z.zip containing the validationtck
sample is that intended?


http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001
File samples/build.xml (right):

http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001#newcode46
samples/build.xml:46: <gwt.ant dir="validation" />
This should be <gwt.ant dir="validationtck" /> if we want the
ValidationTck sample to appear in the generated gwt-x.y.z.zip
distribution.

But with that the ant build fails because there is no war folder under
samples/validationtck.

http://gwt-code-reviews.appspot.com/1085801/diff/3001/4002
File samples/common.ant.xml (right):

http://gwt-code-reviews.appspot.com/1085801/diff/3001/4002#newcode159
samples/common.ant.xml:159: <exclude name="org/**/super/org/**/*.java"/>
Do we really need to disable Checkstyle from all samples? Checkstyle is
supposed to be able to deal with super source.

http://gwt-code-reviews.appspot.com/1085801/diff/3001/4021
File
samples/validationtck/src/org/testng/super/org/testng/ITestNGMethod.java
(right):

http://gwt-code-reviews.appspot.com/1085801/diff/3001/4021#newcode2
samples/validationtck/src/org/testng/super/org/testng/ITestNGMethod.java:2:
// removed reflect.Method
Move these comments to the class documentation.

http://gwt-code-reviews.appspot.com/1085801/diff/3001/4021#newcode7
samples/validationtck/src/org/testng/super/org/testng/ITestNGMethod.java:7:
//import java.lang.reflect.Method;
Delete

http://gwt-code-reviews.appspot.com/1085801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to