http://gwt-code-reviews.appspot.com/1097801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/jetty/JDBCUnloader.java
(right):

http://gwt-code-reviews.appspot.com/1097801/diff/1/2#newcode33
dev/core/src/com/google/gwt/dev/shell/jetty/JDBCUnloader.java:33: public
static void unload() {
Could you avoid making the reflective call by just making this a clinit
instead?

http://gwt-code-reviews.appspot.com/1097801/diff/1/3
File dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java
(right):

http://gwt-code-reviews.appspot.com/1097801/diff/1/3#newcode616
dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java:616: * in
the Apache Tomcat project at
You should describe the modifications, which in this case I presume are
all about GWT's logging, right?

http://gwt-code-reviews.appspot.com/1097801/diff/1/3#newcode628
dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java:628:
private void jreLeakPrevention(TreeLogger logger) {
Is there a reason this isn't static?

http://gwt-code-reviews.appspot.com/1097801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to