Feedbacked, PTAL
http://gwt-code-reviews.appspot.com/1098801/diff/1/2 File user/src/com/google/gwt/requestfactory/server/Logging.java (right): http://gwt-code-reviews.appspot.com/1098801/diff/1/2#newcode45 user/src/com/google/gwt/requestfactory/server/Logging.java:45: // by the deobfuscation code. On 2010/11/11 13:43:13, NotBobV wrote:
Make this a block comment while you're in the area.
Done. http://gwt-code-reviews.appspot.com/1098801/diff/1/4 File user/src/com/google/gwt/requestfactory/server/UserInformation.java (right): http://gwt-code-reviews.appspot.com/1098801/diff/1/4#newcode26 user/src/com/google/gwt/requestfactory/server/UserInformation.java:26: new ThreadLocal<UserInformation>(); On 2010/11/11 13:43:13, NotBobV wrote:
Add a comment explaining why thread re-use won't cause old user
information to
be associated with the current request.
Done. http://gwt-code-reviews.appspot.com/1098801/diff/1/6 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/1098801/diff/1/6#newcode751 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:751: String logRecordJson = new StringBuilder("{").append("\"level\": \"ALL\", ") Nope. On 2010/11/11 13:43:13, NotBobV wrote:
Do you have time to convert the logging stuff to AutoBeans?
http://gwt-code-reviews.appspot.com/1098801/diff/1/6#newcode2011 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:2011: EntityProxyId<UserInformationProxy> stableId = (EntityProxyId<UserInformationProxy>) getResponse.stableId(); On 2010/11/11 13:43:13, NotBobV wrote:
This test is going to break when UIP is made into a value object,
since it will
no longer have a stableId().
Snipped. http://gwt-code-reviews.appspot.com/1098801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
