LGTM. It does trigger an error on Chrome as well.
On Wed, Nov 17, 2010 at 4:25 AM, <[email protected]> wrote: > Reviewers: conroy, > > Description: > In a previous patch, I fixed the doc.findElements... function to be > document.findElements, which uncovered > this bug where we were calling append rather than appendChild, which > hoses on Safari. I'm not sure why > it was ok for Chrome, which is where we tested the original fix... > > > Please review this at http://gwt-code-reviews.appspot.com/1118801/show > > Affected files: > M dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js > > > Index: dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js > =================================================================== > --- dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js (revision > 9233) > +++ dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js (working > copy) > @@ -215,8 +215,8 @@ > obj.CLASSID = 'CLSID:1D6156B6-002B-49E7-B5CA-C138FB843B4E'; > > var dochead = document.getElementsByTagName('head')[0]; > - dochead.append(embed); > - dochead.append(obj); > + dochead.appendChild(embed); > + dochead.appendChild(obj); > } > > function findPluginObject() { > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
