LGTM

thanks for taking the time to make an easy to review diff.


http://gwt-code-reviews.appspot.com/1113801/diff/1/17
File dev/core/src/com/google/gwt/core/ext/typeinfo/JRawType.java
(right):

http://gwt-code-reviews.appspot.com/1113801/diff/1/17#newcode2
dev/core/src/com/google/gwt/core/ext/typeinfo/JRawType.java:2: *
Copyright 2008 Google Inc.
date

http://gwt-code-reviews.appspot.com/1113801/diff/1/19
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):

http://gwt-code-reviews.appspot.com/1113801/diff/1/19#newcode21
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:21: public
interface JType {
General comment: as a part of this refactoring effort, I feel it would
be helpful to finish documenting these interfaces.   It won't be as
simple to read anymore as just reading the method body, seeing as we
will have multiple implementations.

http://gwt-code-reviews.appspot.com/1113801/diff/1/32
File dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java
(right):

http://gwt-code-reviews.appspot.com/1113801/diff/1/32#newcode704
dev/core/src/com/google/gwt/dev/javac/typemodel/JClassType.java:704: //
TODO: Rename this to isRaw
Do we still want to do this?  TODO(name?)

http://gwt-code-reviews.appspot.com/1113801/diff/1/48
File dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
(right):

http://gwt-code-reviews.appspot.com/1113801/diff/1/48#newcode525
dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java:525:
public long getReloadCount() {
Unrelated, but it looks like we're continuing to maintain dead code.  I
see it is implemented elsewhere, but in the end, does this method have
any callers? (I can't find it)

http://gwt-code-reviews.appspot.com/1113801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to