http://gwt-code-reviews.appspot.com/1120801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js
(right):

http://gwt-code-reviews.appspot.com/1120801/diff/1/2#newcode322
dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js:322: if
(maybePlugin != null && maybePlugin.init(window)) {
I see, so we may find a non-null plugin that doesn't init, in which case
we have to keep searching rather than erroring out.

http://gwt-code-reviews.appspot.com/1120801/diff/1/2#newcode331
dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js:331:
pluginConnectionError(codeServer);
Are you sure this should be a connection error?  Returning null will:
loadIframe("http://gwt.google.com/missing-plugin/";);

However, if you call pluginConnectionError, it will show the "failed to
connect" popup and load the TroubleshootingOOPHM iframe, which preempts
the loading of the missing plugin iframe.

Therefore, if we really are missing the plugin, we need to return null
without the connection error.

At this point, it's hard to tell if there never was a maybePlugin, or
whether there was and it just didn't init.  I'm not 100% sure which of
those corresponds to there not being a plugin vs. a real connection
error - do you know?

http://gwt-code-reviews.appspot.com/1120801/diff/1/2#newcode334
dev/core/src/com/google/gwt/core/ext/linker/impl/devmode.js:334: if
(!plugin.init(window)) {
When will this happen?  From what I can tell, plugin will not be
assigned, unless maybePlugin.init(window) succeeded?

http://gwt-code-reviews.appspot.com/1120801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to