http://gwt-code-reviews.appspot.com/1121801/diff/1/2 File user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java (right):
http://gwt-code-reviews.appspot.com/1121801/diff/1/2#newcode34 user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:34: public class HasAlignmentParser implements ElementParser { On 2010/11/18 19:34:50, sbrubaker wrote:
On 2010/11/18 18:22:17, rjrjr wrote: > No reason for these to be inner classes.
These classes were inlined per your comment at http://gwt-code-reviews.appspot.com/1109801/diff/1/5#newcode1000,
Yes, but they're not as inlined as they sensibly could be.
but on further thought I think it makes more sense to keep them as separate classes
and
register these parsers as well. This solves the alignment issue for
any class
that implements HasHorizontalAlignment or HasVerticalAlignment, and
there's no
harm done to classes that implement HasAlignment (since the relevant
attributes
are consumed by the first parser pass).
My comment there suggested doing that iff it would actually solve any problems. The fact that you had to create HasAlignment to solve the actual bug at hand made me wonder. What will be fixed by the existence of HasHorizontalAlignment and HasVerticalAlignment? http://gwt-code-reviews.appspot.com/1121801/diff/1/2#newcode37 user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:37: * Parses widgets that inherit from {...@link com.google.gwt.user.client.ui.HasHorizontalAlignment}. On 2010/11/18 19:34:50, sbrubaker wrote:
On 2010/11/18 18:22:17, rjrjr wrote: > A lot of long lines. Please check your auto format settings.
Ran this file through checkstyle again and not seeing any issues.
Checkstyle doesn't enforce line length. None the less, GWT code is expected to wrap at 80 characters. Please use our standard autoformat settings, per trunk/eclipse/README.txt http://gwt-code-reviews.appspot.com/1121801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
