fabio, can you respond to the windows questions?
http://gwt-code-reviews.appspot.com/1084801/diff/57001/58001 File plugins/npapi/DevModeOptions/.classpath (right): http://gwt-code-reviews.appspot.com/1084801/diff/57001/58001#newcode3 plugins/npapi/DevModeOptions/.classpath:3: <classpathentry kind="src" path="src"/> On 2010/11/18 22:02:02, jat wrote:
Shouldn't this use a linked resource relate to GWT_ROOT, and the
eclipse files
be under $GWT_ROOT/eclipse?
yeah, i'll fix this. http://gwt-code-reviews.appspot.com/1084801/diff/57001/58012 File plugins/npapi/DevModeOptions/src/com/google/gwt/devmodeoptions/client/LocalStorage.java (right): http://gwt-code-reviews.appspot.com/1084801/diff/57001/58012#newcode56 plugins/npapi/DevModeOptions/src/com/google/gwt/devmodeoptions/client/LocalStorage.java:56: return this.setItem(key, JSON.stringify(dataObject)); On 2010/11/18 22:02:02, jat wrote:
Why return for a void method?
because I blindly copied from speedtracer which also does this....fixed locally. http://gwt-code-reviews.appspot.com/1084801/diff/57001/58024 File plugins/npapi/main.cpp (right): http://gwt-code-reviews.appspot.com/1084801/diff/57001/58024#newcode26 plugins/npapi/main.cpp:26: DisableThreadLibraryCalls(hModule); On 2010/11/18 22:02:02, jat wrote:
Spacing.
fixed locally. http://gwt-code-reviews.appspot.com/1084801/diff/57001/58024#newcode242 plugins/npapi/main.cpp:242: return 0 ; On 2010/11/18 22:02:02, jat wrote:
IIUC, this means we silently ignore any events rather than report them
as
unhandled -- is that right?
Chrome calls NPP_HandleEvent in its paint loop on OSX as a workaround for the fact that OSX doesn't support child windows. This is theoretically our opportunity to draw on screen for OSX, but we're not doing that. According to the API, if we aren't handling the event we should return 0. http://gwt-code-reviews.appspot.com/1084801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
