http://gwt-code-reviews.appspot.com/1126801/diff/2002/6002 File samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTable.java (right):
http://gwt-code-reviews.appspot.com/1126801/diff/2002/6002#newcode178 samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTable.java:178: cellTable.addColumn(checkColumn, SafeHtmlUtils.fromSafeConstant("<br>")); On 2010/11/22 21:58:24, pdr wrote:
This wasn't added in this patch, but should this be "<br/>" to be
valid xhtml? Done. http://gwt-code-reviews.appspot.com/1126801/diff/2002/6003 File user/src/com/google/gwt/cell/client/CheckboxCell.java (right): http://gwt-code-reviews.appspot.com/1126801/diff/2002/6003#newcode67 user/src/com/google/gwt/cell/client/CheckboxCell.java:67: * @param handlesSelection true if the cell modifies the selection satte On 2010/11/22 21:58:24, pdr wrote:
typo: satte -> state
Done. http://gwt-code-reviews.appspot.com/1126801/diff/2002/6004 File user/src/com/google/gwt/user/cellview/client/AbstractHasData.java (right): http://gwt-code-reviews.appspot.com/1126801/diff/2002/6004#newcode395 user/src/com/google/gwt/user/cellview/client/AbstractHasData.java:395: public T getVisibleItem(int indexOnPage) { The javadoc is inherited from HasData. We only need to javadoc getVisibleItems() because it returns an immutable list, which is not specified in the interface. http://gwt-code-reviews.appspot.com/1126801/diff/2002/6016 File user/test/com/google/gwt/cell/client/CheckboxCellTest.java (right): http://gwt-code-reviews.appspot.com/1126801/diff/2002/6016#newcode49 user/test/com/google/gwt/cell/client/CheckboxCellTest.java:49: } To scope "cell" so I don't have to worry about accidentally referencing the wrong one. http://gwt-code-reviews.appspot.com/1126801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
