Ok, lgtm (<crosses fingers this time!> :) )
On Mon, Nov 22, 2010 at 1:09 PM, Jason Rosenberg <[email protected]> wrote: > Ray, > > Good question, but yeah, that case will be handled too. Leaf types > don't get visited for arrays at all (thus the root cause of this > problem). I have added another test case with the Enum[][] > reference, I'll commit that and add to the patch shortly. > > Jason > > On Mon, Nov 22, 2010 at 3:15 PM, <[email protected]> wrote: >> >> http://gwt-code-reviews.appspot.com/1133801/diff/1/5 >> File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java >> (right): >> >> http://gwt-code-reviews.appspot.com/1133801/diff/1/5#newcode650 >> dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java:650: JType >> leafType = aType.getLeafType(); >> Does this handle Enum[][]? I'm forgot how the type remapper works, but >> will it visit the innermost Enum[] separately? >> >> http://gwt-code-reviews.appspot.com/1133801/show >> > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
