Feedback implemented.
http://gwt-code-reviews.appspot.com/1148801/diff/1/3 File user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java (right): http://gwt-code-reviews.appspot.com/1148801/diff/1/3#newcode290 user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java:290: return true; On 2010/11/24 18:29:31, rchandia wrote:
Move these two statements into the previous == null case to make the
logic
easier to follow
Done. http://gwt-code-reviews.appspot.com/1148801/diff/1/3#newcode328 user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java:328: && sameOrEquals(map.values(), otherMap.values(), pending); On 2010/11/24 18:29:31, rchandia wrote:
How does this work if sameOrEquals(Collection, Collection) relies on
element
iteration order?
Changed the comparison of collections to ordered-lists and bag semantics. Updated javadoc to match. http://gwt-code-reviews.appspot.com/1148801/diff/1/4 File user/src/com/google/gwt/requestfactory/shared/DefaultProxyStore.java (right): http://gwt-code-reviews.appspot.com/1148801/diff/1/4#newcode35 user/src/com/google/gwt/requestfactory/shared/DefaultProxyStore.java:35: * MyFooProxy someProxy = ...; On 2010/11/24 18:29:31, rchandia wrote:
Describe (or hint) how entity sparseness relates to what gets
serialized. Moved the sample to the ProxySerializer JavaDoc, since that seems a more obvious place to look. Added a comment about sparse objects. http://gwt-code-reviews.appspot.com/1148801/diff/1/12 File user/src/com/google/gwt/requestfactory/shared/impl/ValueProxyCategory.java (right): http://gwt-code-reviews.appspot.com/1148801/diff/1/12#newcode25 user/src/com/google/gwt/requestfactory/shared/impl/ValueProxyCategory.java:25: * Contains static implementation of EntityProxy-specific methods. On 2010/11/24 19:16:09, rchandia wrote:
EntityProxy -> ValueProxy
Done. http://gwt-code-reviews.appspot.com/1148801/diff/1/14 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/1148801/diff/1/14#newcode735 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:735: "\"timestamp\": \"1234567890\",").append("\"thrown\": {}").append("}").toString(); On 2010/11/24 19:16:09, rchandia wrote:
Formatting degraded.
Done. http://gwt-code-reviews.appspot.com/1148801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
