Thanks for the review; updated as per your comments.
http://gwt-code-reviews.appspot.com/1149801/diff/1/3 File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java (right): http://gwt-code-reviews.appspot.com/1149801/diff/1/3#newcode139 dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java:139: "An exception occured while attempting to send a response message.", e); On 2010/11/25 03:29:19, scottb wrote:
Just to be clear.... what logger is this going to go to? Because if
it's going
to try to go to the GPE logger, you could trigger an infinite error
loop. No, I was assuming that this would go to the ConsoleLogger. I guess it would be better to be more explicit here; I'll change it to getConsoleLogger(). http://gwt-code-reviews.appspot.com/1149801/diff/1/5 File dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceTreeLogger.java (right): http://gwt-code-reviews.appspot.com/1149801/diff/1/5#newcode150 dev/core/src/com/google/gwt/dev/shell/remoteui/ViewerServiceTreeLogger.java:150: t.printStackTrace(System.err); On 2010/11/25 03:29:19, scottb wrote:
The zero-arg version goes to System.err, unless you just want to be
real
explicit here.
Ah, I didn't know that, but I did want to be explicit :). http://gwt-code-reviews.appspot.com/1149801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
