[gwt-contrib] Fix some timeout typos, and increase delay on RequestFactoryTest. (issue1163801)

Tue, 30 Nov 2010 11:01:25 -0800 

Reviewers: jgw,

Description:
Fix some timeout typos, and increase delay on RequestFactoryTest.


Please review this at http://gwt-code-reviews.appspot.com/1163801/show

Affected files:
M user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java 
  M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
  M user/test/com/google/gwt/requestfactory/shared/LocatorTest.java
Index: user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java 
===================================================================
--- user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java (revision 9305) +++ user/test/com/google/gwt/requestfactory/client/RequestFactoryExceptionHandlerTest.java (working copy) 
@@ -25,6 +25,8 @@
  */
public class RequestFactoryExceptionHandlerTest extends RequestFactoryTest { 

+  private static final int DELAY_TEST_FINISH = 5000;
+
   @Override
   public String getModuleName() {
return "com.google.gwt.requestfactory.RequestFactoryExceptionHandlerTest"; 
@@ -32,7 +34,7 @@

   @Override
   public void testServerFailureCheckedException() {
-    delayTestFinish(5000);
+    delayTestFinish(DELAY_TEST_FINISH);
     SimpleFooRequest context = req.simpleFooRequest();
     SimpleFooProxy rayFoo = context.create(SimpleFooProxy.class);
final Request<SimpleFooProxy> persistRay = context.persistAndReturnSelf().using( 
@@ -46,7 +48,7 @@

   @Override
   public void testServerFailureRuntimeException() {
-    delayTestFinish(5000);
+    delayTestFinish(DELAY_TEST_FINISH);
     SimpleFooRequest context = req.simpleFooRequest();
     SimpleFooProxy rayFoo = context.create(SimpleFooProxy.class);
final Request<SimpleFooProxy> persistRay = context.persistAndReturnSelf().using( Index: user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java 
===================================================================
--- user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (revision 9305) +++ user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (working copy) 
@@ -172,7 +172,7 @@
     }
   }

-  private static final int DELAY_TEST_FINISH = 5000;
+  private static final int DELAY_TEST_FINISH = 10 * 1000;
public <T extends EntityProxy> void assertContains(Collection<T> col, T value) { 
     EntityProxyId<?> lookFor = value.stableId();
@@ -581,7 +581,7 @@
   }

   public void testFindFindEdit() {
-    delayTestFinish(5000);
+    delayTestFinish(DELAY_TEST_FINISH);
final SimpleFooEventHandler<SimpleFooProxy> handler = new SimpleFooEventHandler<SimpleFooProxy>(); 
     EntityProxyChange.registerForProxyType(req.getEventBus(),
Index: user/test/com/google/gwt/requestfactory/shared/LocatorTest.java
===================================================================
--- user/test/com/google/gwt/requestfactory/shared/LocatorTest.java (revision 9305) +++ user/test/com/google/gwt/requestfactory/shared/LocatorTest.java (working copy) 
@@ -89,7 +89,7 @@
   };

   private static final String ID = "DomainId";
-  private static final int TEST_DELAY = 500;
+  private static final int TEST_DELAY = 5000;

   private Factory factory;



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to