Reviewers: rjrjr, jat,
Description:
This is critical for us; could you please include it in 2.1.1?
I'm not sure about the test (re. i18n involved through NumberFormat) but
I'm sure about the fix!
Please review this at http://gwt-code-reviews.appspot.com/1170801/show
Affected files:
user/src/com/google/gwt/text/client/DoubleParser.java
user/test/com/google/gwt/text/client/DoubleParserTest.java
Index: user/src/com/google/gwt/text/client/DoubleParser.java
===================================================================
--- user/src/com/google/gwt/text/client/DoubleParser.java (revision 9323)
+++ user/src/com/google/gwt/text/client/DoubleParser.java (working copy)
@@ -46,7 +46,7 @@
}
try {
- return
Math.rint(NumberFormat.getDecimalFormat().parse(object.toString()));
+ return NumberFormat.getDecimalFormat().parse(object.toString());
} catch (NumberFormatException e) {
throw new ParseException(e.getMessage(), 0);
}
Index: user/test/com/google/gwt/text/client/DoubleParserTest.java
===================================================================
--- user/test/com/google/gwt/text/client/DoubleParserTest.java (revision
9323)
+++ user/test/com/google/gwt/text/client/DoubleParserTest.java (working
copy)
@@ -30,7 +30,7 @@
}
public void testOuroborus() throws ParseException {
- assertEquals("123",
DoubleRenderer.instance().render(DoubleParser.instance().parse("123")));
+ assertEquals("123.4",
DoubleRenderer.instance().render(DoubleParser.instance().parse("123.4")));
}
public void testNull() throws ParseException {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
