Great docs!

My only complaint is the CssColor/FillStyle/StrokeStyle methods. I think
it's odd how we wrap CssColor in an array, so I'd like to save people
the trouble and point it out.


http://gwt-code-reviews.appspot.com/1165801/diff/1/7
File user/src/com/google/gwt/canvas/dom/client/Context2d.java (right):

http://gwt-code-reviews.appspot.com/1165801/diff/1/7#newcode570
user/src/com/google/gwt/canvas/dom/client/Context2d.java:570: * @see
CssColor
I think a note is needed here, or a comment in the method for why we
have different methods depending on whether it's devmode or webmode
because it's not obvious.

http://gwt-code-reviews.appspot.com/1165801/diff/1/7#newcode715
user/src/com/google/gwt/canvas/dom/client/Context2d.java:715: * @see
CssColor
I think a note is needed here, or a comment in the method for why we
have different methods depending on whether it's devmode or webmode
because it's not obvious.

http://gwt-code-reviews.appspot.com/1165801/diff/1/7#newcode864
user/src/com/google/gwt/canvas/dom/client/Context2d.java:864: * @see
CssColor
I think a note is needed here, or a comment in the method for why we
have different methods depending on whether it's devmode or webmode
because it's not obvious.

http://gwt-code-reviews.appspot.com/1165801/diff/1/7#newcode1043
user/src/com/google/gwt/canvas/dom/client/Context2d.java:1043: * @see
CssColor
I think a note is needed here, or a comment in the method for why we
have different methods depending on whether it's devmode or webmode
because it's not obvious.

http://gwt-code-reviews.appspot.com/1165801/diff/1/7#newcode1178
user/src/com/google/gwt/canvas/dom/client/Context2d.java:1178: *
I think a note is needed here, or as a comment in the method for what's
happening (CssColor is being wrapped in an array.)

http://gwt-code-reviews.appspot.com/1165801/diff/1/7#newcode1201
user/src/com/google/gwt/canvas/dom/client/Context2d.java:1201: *
I think a note is needed here, or as a comment in the method for what's
happening (CssColor is being wrapped in an array.)

http://gwt-code-reviews.appspot.com/1165801/diff/1/7#newcode1224
user/src/com/google/gwt/canvas/dom/client/Context2d.java:1224: *
I think a note is needed here, or as a comment in the method for what's
happening (CssColor is being unwrapped from an array.)

http://gwt-code-reviews.appspot.com/1165801/diff/1/7#newcode1246
user/src/com/google/gwt/canvas/dom/client/Context2d.java:1246: *
I think a note is needed here, or as a comment in the method for what's
happening (CssColor is being unwrapped from an array.)

http://gwt-code-reviews.appspot.com/1165801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to