LGTM

http://gwt-code-reviews.appspot.com/1172801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java
(right):

http://gwt-code-reviews.appspot.com/1172801/diff/1/2#newcode65
dev/core/src/com/google/gwt/dev/shell/JavaDispatchImpl.java:65: throw
new RuntimeException("Field does not exist.");
Is a plain RTE appropriate here?  Would HostedModeException be better,
since it seems to indicate either someone doing something they shouldn't
or something gone seriously wrong?

Likewise the two places below.

http://gwt-code-reviews.appspot.com/1172801/diff/1/3
File dev/core/src/com/google/gwt/dev/shell/Jsni.java (right):

http://gwt-code-reviews.appspot.com/1172801/diff/1/3#newcode118
dev/core/src/com/google/gwt/dev/shell/Jsni.java:118: }
This does mean that if you have bad JSNI that was never called, this
change will stop your code from working.

I'm not objecting, just wanting to make sure this is a conscious change.

http://gwt-code-reviews.appspot.com/1172801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to