Summary of face to face feedback

http://gwt-code-reviews.appspot.com/1167801/diff/1/2
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):

http://gwt-code-reviews.appspot.com/1167801/diff/1/2#newcode1079
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1079: }
I'm trying to figure out why this section of code is actually needed at
all.  Shouldn't the other change pretty much handle things?  Trying to
figure out a situation in which we'd want the user to see this error
message as opposed to the other one.

http://gwt-code-reviews.appspot.com/1167801/diff/1/2#newcode1150
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1150: }
I would actually consider refactoring this method to never return null,
but throw new ClassNotFound() instead, with an appropriate description.

http://gwt-code-reviews.appspot.com/1167801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to