The binaries are part of the CL. it seems that rietveld does not show them, but you can see them in the internal tool.
Also, legal cleared the inclusion of wix binaries under third_party. I added a README.txt under wix folder as suggested by legal (please eyeball it to make sure I did not write anything outrageous). http://gwt-code-reviews.appspot.com/1116801/diff/9001/10004 File plugins/ie/installer/README.txt (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10004#newcode16 plugins/ie/installer/README.txt:16: 4) Test the installation. Yes, make sure it works on x86, x64, it cleans the registry and folder upon uninstall, etc. On 2010/12/01 16:46:48, jat wrote:
Should stick to 80 columns in the text files.
Done. http://gwt-code-reviews.appspot.com/1116801/diff/9001/10005 File plugins/ie/installer/build.cmd (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10005#newcode28 plugins/ie/installer/build.cmd:28: %~dp0wix\heat.exe file %BINARY_DIR%\%BINARY_FILE% -v -nologo -gg -g1 -dr INSTALLDIR -generate components -directoryid ff -cg oophmDll -out %~dp0oophm.wxs -var var.binDir On 2010/12/01 16:46:48, jat wrote:
What are the %~dp0* references?
%~dp0 references the folder where the script is (that is different from %cd% as %cd% can change by script commands, whereas dp0 can be thought as the 'physical' location of the script). http://gwt-code-reviews.appspot.com/1116801/diff/9001/10009 File plugins/ie/installer/oophm.wxs (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10009#newcode2 plugins/ie/installer/oophm.wxs:2: <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi";> On 2010/12/01 16:46:48, jat wrote:
Maybe this file should be renamed to DevModePlugin.wxs or something
like that --
while it isn't worth it to clean up existing references to OOPHM in
names, we
probably shouldn't add any more.
You should also get jlabanca to look over the WIX files, since he got
that
working initially.
I will consider renaming on another change. since all references are to oophm, I would keep this name for the sake of consistency. please let me know if you feel strongly about this. Also, will fw to jlabanca for cr as well. http://gwt-code-reviews.appspot.com/1116801/diff/9001/10014 File plugins/ie/oophm/oophm/dllmain.cpp (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10014#newcode34 plugins/ie/oophm/oophm/dllmain.cpp:34: DisableThreadLibraryCalls(hInstance); On 2010/12/01 16:46:48, jat wrote:
Use spaces instead of tabs on these lines.
Done. http://gwt-code-reviews.appspot.com/1116801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
