Re posting as http://gwt-code-reviews.appspot.com/1181802
Ovet there I changed the test to use 123.5 to avoid roundoff issues. On 2010/12/01 16:55:56, jat wrote:
On Wed, Dec 1, 2010 at 11:52 AM, Ray Ryan <mailto:[email protected]>
wrote:
> I'll get it in today, thanks very much for the patch. > > I suspect this is the cause of > http://code.google.com/p/google-web-toolkit/issues/detail?id=5460 >
Note if you are going to take care of the patch, you need to make sure
the
double comparison avoids roundoff on all browsers (you would be
surprised
how much it differs, as I found out doing the BigDecimal/NumberFormat
work).
I would recommend .5 as the fraction, since there can't be any
round-off.
-- John A. Tamplin Software Engineer (GWT), Google
http://gwt-code-reviews.appspot.com/1170801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
