LGTM
looks like this crept in in the massive r8946. In addition to being
moved, the parse method was changed from
public Double parse(CharSequence object) throws ParseException {
- try {
- return Double.valueOf(object.toString());
- } catch (NumberFormatException e) {
- throw new ParseException(e.getMessage(), 0);
- }
- }
to
<<<<<
public Double parse(CharSequence object) throws ParseException {
+ if ("".equals(object.toString())) {
+ return null;
+ }
+
try {
- return Double.valueOf(object.toString());
+ return
Math.rint(NumberFormat.getDecimalFormat().parse(object.toString()));
} catch (NumberFormatException e) {
throw new ParseException(e.getMessage(), 0);
}
On 2010/12/02 22:45:38, rchandia wrote:
Gah! I meant:
http://gwt-code-reviews.appspot.com/1170801
El 2 de diciembre de 2010 17:40, Chris Conroy
<mailto:con...@google.com> escribió:
> that's a link to this review :P
>
>
> On Thu, Dec 2, 2010 at 5:39 PM, <mailto:rchan...@google.com> wrote:
>
>> This is actually a repost of tboryer's patch originally submitted
at:
>>
>>
>> http://gwt-code-reviews.appspot.com/1181802
>>
>> On 2010/12/02 22:33:23, rchandia wrote:
>>
>>
>>
>>
>> http://gwt-code-reviews.appspot.com/1181802/show
>>
>
>
http://gwt-code-reviews.appspot.com/1181802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
