http://gwt-code-reviews.appspot.com/1185801/diff/1/3
File
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/ValidationRequirementTest.java
(right):

http://gwt-code-reviews.appspot.com/1185801/diff/1/3#newcode53
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/ValidationRequirementTest.java:53:
public void notestIgnoreStaticFieldsAndProperties() {
We will never run this. But I want to keep track of what I don't run and
why.

Eventually I will grep for the tests for counts.

The test source says


//      @SpecAssertion(section = "3.1",
//                      id = "b",
//                      note = "The spec is not clear about whether validation 
of static
fields/properties should just be ignored or an exception should be
thrown.")

http://gwt-code-reviews.appspot.com/1185801/diff/1/6
File
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/1185801/diff/1/6#newcode418
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:418:
*/
On 2010/12/09 18:30:57, rchandia wrote:
Delete or fill-in

Done.

http://gwt-code-reviews.appspot.com/1185801/diff/3001/4005#newcode538
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:538:
sw.println("    new HashSet<ConstraintViolation<T>>();");
On 2010/12/09 18:30:57, rchandia wrote:
Use sw.indent and sw.outdent

Done.

http://gwt-code-reviews.appspot.com/1185801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to