Forgot to send these. notes. thanks for the lgtm. 2 more CLs waiting.
http://gwt-code-reviews.appspot.com/1206801/diff/1/2 File samples/validation/src/com/google/gwt/sample/validation/shared/Person.java (right): http://gwt-code-reviews.appspot.com/1206801/diff/1/2#newcode38 samples/validation/src/com/google/gwt/sample/validation/shared/Person.java:38: On 2010/12/09 22:52:24, rchandia wrote:
Checkstyle
Done. http://gwt-code-reviews.appspot.com/1206801/diff/1/2#newcode50 samples/validation/src/com/google/gwt/sample/validation/shared/Person.java:50: protected long getSsn() { On 2010/12/09 22:52:24, rchandia wrote:
Checkstyle error
Done. http://gwt-code-reviews.appspot.com/1206801/diff/1/4 File samples/validationtck/style/text/junit-noframes.xsl (right): http://gwt-code-reviews.appspot.com/1206801/diff/1/4#newcode45 samples/validationtck/style/text/junit-noframes.xsl:45: <xsl:value-of select="$passedCount" /> <xsl:text> Pass </xsl:text> Reformatted as 6 of 258 (2.33%) Pass with 6 Failures and 29 Errors. http://gwt-code-reviews.appspot.com/1206801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
