http://gwt-code-reviews.appspot.com/1215801/diff/1/4 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231 dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231: eventsByGeneratorType.put("com.google.gwt.resources.rebind.context.InlineClientBundleGenerator", CompilerEventType.GENERATOR_CLIENT_BUNDLE); line length > 100 http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231 dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231: eventsByGeneratorType.put("com.google.gwt.resources.rebind.context.InlineClientBundleGenerator", CompilerEventType.GENERATOR_CLIENT_BUNDLE); Wouldn't it be more robust to refer to these types by class constants? I know it would introduce dependencies through import statements, but in effect, the code does depend on these classes by using their package names like this, and will silently break if there is some refactoring. Or maybe it would be better to include an extendable method for Generator to return a SpeedTracer event type. http://gwt-code-reviews.appspot.com/1215801/diff/1/6 File dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java (right): http://gwt-code-reviews.appspot.com/1215801/diff/1/6#newcode49 dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java:49: if (jsniMethod.isScriptOnly()) { I would appreciate a comment here that this is for a performance optimization. http://gwt-code-reviews.appspot.com/1215801/diff/1/13 File user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java (right): http://gwt-code-reviews.appspot.com/1215801/diff/1/13#newcode27 user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:27: // as the syntax is correct, e.g. "[[Ljava.lang.String;" I'm not sure its so surprising the names match, since the SerializationUtils.getRpcTypeName() is explicitly documented as such. Maybe reference that method? http://gwt-code-reviews.appspot.com/1215801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
