http://gwt-code-reviews.appspot.com/1214801/diff/1/2 File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode33 user/src/com/google/gwt/jsonp/client/JsonpRequest.java:33: On 2010/12/13 21:42:50, jat wrote:
Added whitespace.
Done. http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode78 user/src/com/google/gwt/jsonp/client/JsonpRequest.java:78: On 2010/12/13 21:42:50, jat wrote:
Whitespace.
Done. http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode129 user/src/com/google/gwt/jsonp/client/JsonpRequest.java:129: * Create a new JSONP request. On 2010/12/13 21:42:50, jat wrote:
Shouldn't this distinguish from the above constructor, explaining why
this would
be used?
Done. http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode142 user/src/com/google/gwt/jsonp/client/JsonpRequest.java:142: String callbackParam, String failureCallbackParam, String id) { On 2010/12/13 21:42:50, jat wrote:
Need javadoc for id.
Done. http://gwt-code-reviews.appspot.com/1214801/diff/1/6 File user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java (right): http://gwt-code-reviews.appspot.com/1214801/diff/1/6#newcode67 user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:67: On 2010/12/13 21:42:50, jat wrote:
Whitespace.
Done. http://gwt-code-reviews.appspot.com/1214801/diff/1/6#newcode91 user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:91: On 2010/12/13 21:42:50, jat wrote:
Whitespace.
Done. http://gwt-code-reviews.appspot.com/1214801/diff/1/6#newcode154 user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:154: On 2010/12/13 21:42:50, jat wrote:
Whitespace.
Something must be set wrong in your IDE to generate all these where
they didn't
exist previously.
It seems like it doesn't it? I have the gwt formatting stuff imported though, and as far as I can tell, indent is not checked for blank lines... http://gwt-code-reviews.appspot.com/1214801/diff/1/8 File user/test/com/google/gwt/resources/ExternalTextResourceJsonp.gwt.xml (right): http://gwt-code-reviews.appspot.com/1214801/diff/1/8#newcode16 user/test/com/google/gwt/resources/ExternalTextResourceJsonp.gwt.xml:16: <set-configuration-property name="ExternalTextResource.useJsonp" value="true" /> On 2010/12/13 21:42:50, jat wrote:
80 columns
Done. http://gwt-code-reviews.appspot.com/1214801/diff/1/11 File user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java (right): http://gwt-code-reviews.appspot.com/1214801/diff/1/11#newcode26 user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java:26: static interface Resources extends ClientBundleWithLookup { On 2010/12/13 21:42:50, jat wrote:
Why package protected?
Done. http://gwt-code-reviews.appspot.com/1214801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
