Do we want to hide this change initially behind a flag (e.g.
-DXuseByteCodeToBuildTypeOracle)?


http://gwt-code-reviews.appspot.com/1217801/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
(right):

http://gwt-code-reviews.appspot.com/1217801/diff/1/3#newcode256
dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java:256:
I'm not sure why this declaration is transient.  Is TypeOracleMediator
ever serialized?

Also (and this might just be a stylistic point), I think it might be
cleaner to have the context passed down to the methods that need it,
rather than having it be an instance variable.  It might be more of an
issue later if we try to make this multi-threaded (e.g. if multiple
AddNewTypes happen simultaneously).  Of course, this would not be the
only thing that would need refactoring for thread-safety...

http://gwt-code-reviews.appspot.com/1217801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to