On Tue, Dec 21, 2010 at 11:09 AM, <[email protected]> wrote: > On 2010/12/16 19:43:39, rdayal wrote: > >> Is this system property required? >> > > This is a tough one, because I don't think it's strictly required, but > the devjar has things such as the GWT devmode bridge and the GWT > compiler. Can you think of a case where it wouldn't be set though? Let > me ask some non-GPE and non-Eclipse users to add this change and confirm > nothing breaks before asking for the LGTM.
I believe if you are working with GWT instead of *on* GWT, and you aren't using GPE, gwt_devjar is not required and people would have no way of knowing they need to set it. Worse, the error message is going to be misleading for them. I think that error needs to occur only if GPE is being used, or else provide more explanation. gwt_devjar is needed primarily to find shared objects for native libraries (currently only used for Windows proxy support) and WebAppCreator needs it so it uses the right path for the generated build files (and GPE needs it because it calls WAC and I think it may set it automatically for GWT launch configs). -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
