Thanks for the review.
http://gwt-code-reviews.appspot.com/1246801/diff/1/2 File user/src/com/google/gwt/i18n/client/Messages.java (right): http://gwt-code-reviews.appspot.com/1246801/diff/1/2#newcode204 user/src/com/google/gwt/i18n/client/Messages.java:204: * </pre></code> On 2010/12/23 17:51:40, pdr wrote:
Is it safe to explicitly rely on annotation order in Java?
It isn't the order of the annotations on an item but in this case it is the order of the parameters which are annotated with @PluralCount or @Select. http://gwt-code-reviews.appspot.com/1246801/diff/1/6 File user/src/com/google/gwt/i18n/rebind/MessagesMethodCreator.java (right): http://gwt-code-reviews.appspot.com/1246801/diff/1/6#newcode1301 user/src/com/google/gwt/i18n/rebind/MessagesMethodCreator.java:1301: writer.println("switch (arg" + listArgNum + "_size) {"); On 2010/12/23 17:51:40, pdr wrote:
Missing writer.indent();
Done. http://gwt-code-reviews.appspot.com/1246801/diff/1/6#newcode1352 user/src/com/google/gwt/i18n/rebind/MessagesMethodCreator.java:1352: writer.outdent(); On 2010/12/23 17:51:40, pdr wrote:
Missing writer.outdent();
Done. http://gwt-code-reviews.appspot.com/1246801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
