http://gwt-code-reviews.appspot.com/1245801/diff/1/2 File samples/validationtck/build.xml (right):
http://gwt-code-reviews.appspot.com/1245801/diff/1/2#newcode140 samples/validationtck/build.xml:140: executable="${basedir}/countMarkedTests.sh" On 2010/12/23 15:13:32, rchandia wrote:
I think this breaks support for non-unix users.
It does, let me think for a while on how to support this. http://gwt-code-reviews.appspot.com/1245801/diff/1/3 File samples/validationtck/countMarkedTests.sh (right): http://gwt-code-reviews.appspot.com/1245801/diff/1/3#newcode1 samples/validationtck/countMarkedTests.sh:1: #!/bin/bash On 2010/12/23 15:13:32, rchandia wrote:
Use /bin/sh
Done. http://gwt-code-reviews.appspot.com/1245801/diff/1/20 File samples/validationtck/test/com/google/gwt/sample/validationtck/util/Failing.java (right): http://gwt-code-reviews.appspot.com/1245801/diff/1/20#newcode35 samples/validationtck/test/com/google/gwt/sample/validationtck/util/Failing.java:35: * . On 2010/12/23 15:13:32, rchandia wrote:
Hard to understand. Trailing dot.
Done. http://gwt-code-reviews.appspot.com/1245801/diff/1/21 File samples/validationtck/test/com/google/gwt/sample/validationtck/util/NonTckTest.java (right): http://gwt-code-reviews.appspot.com/1245801/diff/1/21#newcode35 samples/validationtck/test/com/google/gwt/sample/validationtck/util/NonTckTest.java:35: * {...@link NonTckTest}. On 2010/12/23 15:13:32, rchandia wrote:
Rephrase
Done. http://gwt-code-reviews.appspot.com/1245801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
