LGTM

The software engineer in me doesn't like this.  It would be better to
use getYear() + 10.  But, for now lets just push the date out even
further.


http://gwt-code-reviews.appspot.com/1248802/diff/1/2
File user/test/com/google/gwt/emultest/java/util/DateTest.java (right):

http://gwt-code-reviews.appspot.com/1248802/diff/1/2#newcode867
user/test/com/google/gwt/emultest/java/util/DateTest.java:867: return
new Date("12/30/2030 3:4:5 GMT");
Why not 2130?  That way you can be sure that you'll be long gone before
the next person has to fix it.

http://gwt-code-reviews.appspot.com/1248802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to