Very nice, as always.

http://gwt-code-reviews.appspot.com/1233803/diff/1/3
File user/src/com/google/gwt/uibinder/elementparsers/TreeItemParser.java
(right):

http://gwt-code-reviews.appspot.com/1233803/diff/1/3#newcode39
user/src/com/google/gwt/uibinder/elementparsers/TreeItemParser.java:39:
for (XMLElement child : elem.consumeChildElements()) {
How about introducing a HasTreeItems interface to be implemented by both
Tree and TreeItem, and combine these two parsers into a single
HasTreeItems parser? They're basically identical, right?

http://gwt-code-reviews.appspot.com/1233803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to