Reviewers: rjrjr, Nick Chalko, Message: Patch updated.
The whole SimpleViolation class exists to accomodate the interim "Violation" interface provided by RequestFactory, since ConstraintViolation in the client was in flux when we were designing the RF API. The Violation API needs to be deprecated and eliminated in the future. Once that's done, SimpleViolation can also go away. http://gwt-code-reviews.appspot.com/1260801/diff/1/3 File user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java (right): http://gwt-code-reviews.appspot.com/1260801/diff/1/3#newcode25 user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:25: * {...@link EditorDelegate#subscribe()}. On 2011/01/06 17:57:10, rjrjr wrote:
Add a note that this interface is implemented by generated code, and
that
incompatible changes may be made from time to time? I should do the
same to
UiBinder
Done. http://gwt-code-reviews.appspot.com/1260801/diff/1/3#newcode85 user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:85: * JSR 303 Validator. The violations will be converted into On 2011/01/06 17:57:10, rjrjr wrote:
Let's try to get away from the JSR verbiage. Just "probably generated
by a
{...@link javax.validation.Validator}."
Done. http://gwt-code-reviews.appspot.com/1260801/diff/1/5 File user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java (right): http://gwt-code-reviews.appspot.com/1260801/diff/1/5#newcode26 user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java:26: public class EditorDriverUtils { On 2011/01/06 17:57:10, rjrjr wrote:
How about changing this to abstract class SimpleViolation, rather than
using the
nested interface? Util classes always give me a misc-rash.
Done. http://gwt-code-reviews.appspot.com/1260801/diff/1/5#newcode32 user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java:32: public static class ConstraintViolationIterable implements On 2011/01/06 17:57:10, rjrjr wrote:
And this doesn't need to be a public type. Could have a static method
SimpleViolation#iterableFromConstraintViolations(Iterable<ConstraintViolation<?>>) Done. http://gwt-code-reviews.appspot.com/1260801/diff/1/9 File user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java (right): http://gwt-code-reviews.appspot.com/1260801/diff/1/9#newcode149 user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java:149: // TODO Auto-generated method stub On 2011/01/06 22:31:02, Nick Chalko wrote:
Remove TODO
Done. Description: Add support for mapping ConstraintViolation objects into SimpleBeanEditor. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/1260801/show Affected files: M user/src/com/google/gwt/editor/Editor.gwt.xml M user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.javaM user/src/com/google/gwt/editor/client/impl/AbstractSimpleBeanEditorDriver.java
A user/src/com/google/gwt/editor/client/impl/SimpleViolation.javaM user/src/com/google/gwt/editor/client/testing/MockSimpleBeanEditorDriver.java M user/src/com/google/gwt/requestfactory/client/RequestFactoryEditorDriver.java M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequestFactoryEditorDriver.java M user/src/com/google/gwt/requestfactory/client/testing/MockRequestFactoryEditorDriver.java
M user/test/com/google/gwt/editor/rebind/model/EditorModelTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
