will upload new patch shortly. Added tests and a sample app, using "violator pattern" to access private members.
http://gwt-code-reviews.appspot.com/1043801/diff/1/8 File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/1043801/diff/1/8#newcode1536 user/src/com/google/gwt/junit/JUnitShell.java:1536: // TODO: figure out if it is possible to allow multiple modules. Modified ProxyFilter to support multiple modules. On 2011/01/01 03:03:44, jat wrote:
On 2010/11/09 19:31:37, kjin wrote: > I'm not sure about it -- E2E tests run for the whole application, so
(to my
> limited experience) there's only one module which contains entry
point.
> OTOH, I'm experimenting with initializing Module Under Test in test
methods,
so > this will be addressed in next pass.
A number of internal GWT apps use multiple modules, each with their
own entry
points.
http://gwt-code-reviews.appspot.com/1043801/diff/14001/15001 File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/1043801/diff/14001/15001#newcode293 dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:293: public String[] getAllSourceFiles() { dunno -- not in my CL. On 2011/01/01 03:03:44, jat wrote:
What is this used for?
http://gwt-code-reviews.appspot.com/1043801/diff/14001/15006 File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/1043801/diff/14001/15006#newcode151 user/src/com/google/gwt/junit/JUnitShell.java:151: protected interface JUnitShellOptions extends HostedModeOptions, OptionProxyTo { On 2011/01/01 03:03:44, jat wrote:
>80 chars
Done. http://gwt-code-reviews.appspot.com/1043801/diff/14001/15006#newcode192 user/src/com/google/gwt/junit/JUnitShell.java:192: return "Proxies non-junithost XHRs to the specified host and port. Implies -startProxy"; On 2011/01/01 03:03:44, jat wrote:
>80 chars
Done. http://gwt-code-reviews.appspot.com/1043801/diff/14001/15006#newcode317 user/src/com/google/gwt/junit/JUnitShell.java:317: return "Starts a proxy which replaces syntheticModuleName with moduleName as fallback"; On 2011/01/01 03:03:44, jat wrote:
This doesn't seem a terribly accurate description. Also, what exactly
does this
do if a proxy server/host wasn't specified?
Done. http://gwt-code-reviews.appspot.com/1043801/diff/14001/15006#newcode327 user/src/com/google/gwt/junit/JUnitShell.java:327: return true; I think this option is only for experimental users, like -batch and -precompile. I could be convinced either way. On 2011/01/01 03:03:44, jat wrote:
Why does this need to be excluded from -help?
http://gwt-code-reviews.appspot.com/1043801/diff/14001/15006#newcode1278 user/src/com/google/gwt/junit/JUnitShell.java:1278: options.setProxyToPort(getPort()); modified; hope it is clearer. The proxy intercepts requests on getPort(), but the -proxyTo host:port is arbitrary, and the default is getHost():getPort() On 2011/01/01 03:03:44, jat wrote:
What will this accomplish? Won't the proxy be running on getPort()?
http://gwt-code-reviews.appspot.com/1043801/diff/14001/15006#newcode1337 user/src/com/google/gwt/junit/JUnitShell.java:1337: Linker l = module.getActivePrimaryLinker().newInstance(); On 2011/01/01 03:03:44, jat wrote:
Use a longer name.
Done. http://gwt-code-reviews.appspot.com/1043801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
