http://gwt-code-reviews.appspot.com/1274801/diff/1/3 File dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java (right):
http://gwt-code-reviews.appspot.com/1274801/diff/1/3#newcode145 dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java:145: ModuleDef moduleDef = (ModuleDef) ClassLoaderLocalMap.get(key, moduleName); I'm sure a separate context per thread makes sense for GWT Designer, but do we want to enforce this constraint in general? I'd prefer we add an overload instead. http://gwt-code-reviews.appspot.com/1274801/diff/1/2 File dev/core/src/com/google/gwt/dev/util/ClassLoaderLocalMap.java (right): http://gwt-code-reviews.appspot.com/1274801/diff/1/2#newcode1 dev/core/src/com/google/gwt/dev/util/ClassLoaderLocalMap.java:1: package com.google.gwt.dev.util; missing opensource header http://gwt-code-reviews.appspot.com/1274801/diff/1/2#newcode17 dev/core/src/com/google/gwt/dev/util/ClassLoaderLocalMap.java:17: * Based on http://java.dzone.com/articles/classloaderlocal-how-avoid I always use an anchor tag for hrefs so they show up nicely in online javadoc. http://gwt-code-reviews.appspot.com/1274801/diff/1/2#newcode38 dev/core/src/com/google/gwt/dev/util/ClassLoaderLocalMap.java:38: private static byte[] buildHolderByteCode(String holderClassName) { I would appreciate a method comment here. http://gwt-code-reviews.appspot.com/1274801/diff/1/2#newcode44 dev/core/src/com/google/gwt/dev/util/ClassLoaderLocalMap.java:44: { I think this code is separated into blocks for readability. That is nice, but stands out as a bit unusual in the GWT code base. Would extra whitespace would accomplish the same purpose? http://gwt-code-reviews.appspot.com/1274801/diff/1/2#newcode75 dev/core/src/com/google/gwt/dev/util/ClassLoaderLocalMap.java:75: public static boolean containsKey(ClassLoader cl, Object key) { GWT style is to sort methods in the file. First all public, then default, then protected, and finally all private methods - each sorted alphabetically. http://code.google.com/webtoolkit/makinggwtbetter.html#codestyle http://gwt-code-reviews.appspot.com/1274801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
