Do similar changes need to be made in Editor, and are you up for that? Bob, are you able to take this review?
On Sun, Jan 9, 2011 at 5:01 AM, <t.bro...@gmail.com> wrote: > > http://gwt-code-reviews.appspot.com/1272801/diff/1/3 > File user/src/com/google/gwt/autobean/server/BeanMethod.java (right): > > http://gwt-code-reviews.appspot.com/1272801/diff/1/3#newcode52 > user/src/com/google/gwt/autobean/server/BeanMethod.java:52: String > inferName(Method method) { > Similar to AutoBeanMethod but using Java reflection. Also, contrary to > AutoBeanMethod, it doesn't decapitalize the name. > > Note that actually only the GET.inferName is ever called. > > http://gwt-code-reviews.appspot.com/1272801/diff/1/6 > File user/src/com/google/gwt/autobean/server/ProxyAutoBean.java (right): > > http://gwt-code-reviews.appspot.com/1272801/diff/1/6#newcode66 > user/src/com/google/gwt/autobean/server/ProxyAutoBean.java:66: Class<?> > returnType = method.getReturnType(); > Oops, I moved that line before factoring "inferName" into BeanMethod and > forgot to undo the move afterwards. > > http://gwt-code-reviews.appspot.com/1272801/diff/1/8 > File > > user/src/com/google/gwt/requestfactory/server/ReflectiveServiceLayer.java > (right): > > http://gwt-code-reviews.appspot.com/1272801/diff/1/8#newcode248 > > user/src/com/google/gwt/requestfactory/server/ReflectiveServiceLayer.java:248: > return domainClass.getMethod("get" + capitalizedProperty); > Should some kind of caching be added? (Map<Class<?>,Map<String,Method>>) > > > http://gwt-code-reviews.appspot.com/1272801/show > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
