Reviewers: jlabanca,
Description:
ColumnSortEvent#isAscending was misspelled. Fixes
http://code.google.com/p/google-web-toolkit/issues/detail?id=5869
Please review this at http://gwt-code-reviews.appspot.com/1283801/show
Affected files:
M user/src/com/google/gwt/user/cellview/client/ColumnSortEvent.java
M user/test/com/google/gwt/user/cellview/client/ColumnSortEventTest.java
Index: user/src/com/google/gwt/user/cellview/client/ColumnSortEvent.java
===================================================================
--- user/src/com/google/gwt/user/cellview/client/ColumnSortEvent.java
(revision 9526)
+++ user/src/com/google/gwt/user/cellview/client/ColumnSortEvent.java
(working copy)
@@ -103,7 +103,7 @@
}
// Sort using the comparator.
- if (event.isSortAcsending()) {
+ if (event.isSortAscending()) {
Collections.sort(list, comparator);
} else {
Collections.sort(list, new Comparator<T>() {
@@ -199,7 +199,7 @@
*
* @return true if ascending, false if descending or not sorted
*/
- public boolean isSortAcsending() {
+ public boolean isSortAscending() {
return (sortList == null || sortList.size() == 0) ? false
: sortList.get(0).isAscending();
}
Index:
user/test/com/google/gwt/user/cellview/client/ColumnSortEventTest.java
===================================================================
--- user/test/com/google/gwt/user/cellview/client/ColumnSortEventTest.java
(revision 9526)
+++ user/test/com/google/gwt/user/cellview/client/ColumnSortEventTest.java
(working copy)
@@ -44,7 +44,7 @@
ColumnSortEvent event = new ColumnSortEvent(sortList);
assertEquals(sortList, event.getColumnSortList());
assertEquals(col1, event.getColumn());
- assertFalse(event.isSortAcsending());
+ assertFalse(event.isSortAscending());
}
public void testAsyncHandler() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
