[gwt-contrib] Fixing HasWidgetsTester#testAll to actually call testDoDetachChildrenWithError. Currently, it c... (issue1300801)

[jlabanca]

Reviewers: pdr,

Description:
Fixing HasWidgetsTester#testAll to actually call
testDoDetachChildrenWithError.  Currently, it calls
testDoAttachChildrenWithError twice.  HTMLTableTestBase needs to be
modified to work with the test.

Please review this at http://gwt-code-reviews.appspot.com/1300801/show

Affected files:
  M user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java
  M user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java


Index: user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java
===================================================================
--- user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java	 
(revision 9561)
+++ user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java	(working  
copy)
@@ -33,8 +33,10 @@
  */
 public abstract class HTMLTableTestBase extends GWTTestCase {
   static class Adder implements HasWidgetsTester.WidgetAdder {
+    private int row = -1;
+
     public void addChild(HasWidgets container, Widget child) {
-      ((HTMLTable) container).setWidget(0, 0, child);
+      ((HTMLTable) container).setWidget(++row, 0, child);
     }
   }

@@ -67,7 +69,7 @@
   public abstract HTMLTable getTable(int row, int column);

   public void testAttachDetachOrder() {
-    HasWidgetsTester.testAll(getTable(1, 1), new Adder(), true);
+    HasWidgetsTester.testAll(getTable(25, 1), new Adder(), true);
   }

   public void testBoundsOnEmptyTable() {
Index: user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java
===================================================================
--- user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java	(revision  
9561)
+++ user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java	(working  
copy)
@@ -112,7 +112,7 @@
     testAttachDetachOrder(container, adder);
     testRemovalOfNonExistantChild(container);
     testDoAttachChildrenWithError(container, adder,  
supportsMultipleWidgets);
-    testDoAttachChildrenWithError(container, adder,  
supportsMultipleWidgets);
+    testDoDetachChildrenWithError(container, adder,  
supportsMultipleWidgets);
   }

   /**


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors