http://gwt-code-reviews.appspot.com/1296801/diff/13001/14002 File user/src/com/google/gwt/canvas/client/Canvas.java (right):
http://gwt-code-reviews.appspot.com/1296801/diff/13001/14002#newcode45 user/src/com/google/gwt/canvas/client/Canvas.java:45: CanvasElementSupportDetector detector = GWT.create(CanvasElementSupportDetector.class); Duplicate code, should call isSupported instead. http://gwt-code-reviews.appspot.com/1296801/diff/13001/14002#newcode174 user/src/com/google/gwt/canvas/client/Canvas.java:174: static class CanvasElementSupportDetector { Can this be private? http://gwt-code-reviews.appspot.com/1296801/diff/13001/14003 File user/src/com/google/gwt/dom/client/PartialSupport.java (right): http://gwt-code-reviews.appspot.com/1296801/diff/13001/14003#newcode23 user/src/com/google/gwt/dom/client/PartialSupport.java:23: * supported at runtime. What about the factory method? Even if it's not universally needed, you can document how it will appear when it's appropriate. http://gwt-code-reviews.appspot.com/1296801/diff/13001/14005 File user/test/com/google/gwt/canvas/client/CanvasTest.java (right): http://gwt-code-reviews.appspot.com/1296801/diff/13001/14005#newcode33 user/test/com/google/gwt/canvas/client/CanvasTest.java:33: public class CanvasTest extends GWTTestCase { Doesn't test isSupported. http://gwt-code-reviews.appspot.com/1296801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
