Revision: 9572
Author: [email protected]
Date: Wed Jan 19 08:59:29 2011
Log: Fixing HasWidgetsTester#testAll to actually call
testDoDetachChildrenWithError. Currently, it calls
testDoAttachChildrenWithError twice. HTMLTableTestBase needs to be
modified to work with the test.
Review at http://gwt-code-reviews.appspot.com/1300801
Review by: [email protected]
http://code.google.com/p/google-web-toolkit/source/detail?r=9572
Modified:
/trunk/user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java
/trunk/user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java
=======================================
--- /trunk/user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java
Tue Sep 21 07:53:19 2010
+++ /trunk/user/test/com/google/gwt/user/client/ui/HTMLTableTestBase.java
Wed Jan 19 08:59:29 2011
@@ -33,8 +33,10 @@
*/
public abstract class HTMLTableTestBase extends GWTTestCase {
static class Adder implements HasWidgetsTester.WidgetAdder {
+ private int row = -1;
+
public void addChild(HasWidgets container, Widget child) {
- ((HTMLTable) container).setWidget(0, 0, child);
+ ((HTMLTable) container).setWidget(++row, 0, child);
}
}
@@ -67,7 +69,7 @@
public abstract HTMLTable getTable(int row, int column);
public void testAttachDetachOrder() {
- HasWidgetsTester.testAll(getTable(1, 1), new Adder(), true);
+ HasWidgetsTester.testAll(getTable(25, 1), new Adder(), true);
}
public void testBoundsOnEmptyTable() {
=======================================
--- /trunk/user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java
Wed Sep 23 10:15:52 2009
+++ /trunk/user/test/com/google/gwt/user/client/ui/HasWidgetsTester.java
Wed Jan 19 08:59:29 2011
@@ -112,7 +112,7 @@
testAttachDetachOrder(container, adder);
testRemovalOfNonExistantChild(container);
testDoAttachChildrenWithError(container, adder,
supportsMultipleWidgets);
- testDoAttachChildrenWithError(container, adder,
supportsMultipleWidgets);
+ testDoDetachChildrenWithError(container, adder,
supportsMultipleWidgets);
}
/**
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
