http://gwt-code-reviews.appspot.com/1293801/diff/1/2 File user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/1293801/diff/1/2#newcode41 user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java:41: static PlaceHistoryGeneratorContext create(TreeLogger logger, On 2011/01/21 03:45:50, rjrjr wrote:
javadoc to warn of the null return
Done. http://gwt-code-reviews.appspot.com/1293801/diff/1/3 File user/src/com/google/gwt/place/rebind/PlaceHistoryMapperGenerator.java (right): http://gwt-code-reviews.appspot.com/1293801/diff/1/3#newcode54 user/src/com/google/gwt/place/rebind/PlaceHistoryMapperGenerator.java:54: return null; On 2011/01/21 03:45:50, rjrjr wrote:
Wait, what? What happens when a code generator returns null?
From the JavaDoc at http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/com/google/gwt/core/ext/Generator.html#generate(com.google.gwt.core.ext.TreeLogger, com.google.gwt.core.ext.GeneratorContext, java.lang.String) """ Returns: the name of a subclass to substitute for the requested class, or return null to cause the requested type itself to be used """ http://gwt-code-reviews.appspot.com/1293801/diff/1/4 File user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java (right): http://gwt-code-reviews.appspot.com/1293801/diff/1/4#newcode52 user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java:52: * The goal is only to test that the generator doesn't fail (but doesn't generate anything either). On 2011/01/21 03:45:50, rjrjr wrote:
line too long
Done. http://gwt-code-reviews.appspot.com/1293801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
