http://gwt-code-reviews.appspot.com/1312801/diff/3001/4001
File dev/core/src/com/google/gwt/dev/jjs/ast/JArrayType.java (left):

http://gwt-code-reviews.appspot.com/1312801/diff/3001/4001#oldcode82
dev/core/src/com/google/gwt/dev/jjs/ast/JArrayType.java:82:
You're exactly right.  All this logic is explicitly handled in
JTypeOracle.canTriviallyCast().

http://www.google.com/codesearch/p?hl=en#A1edwVHBClQ/dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java&l=366

ArrayType.getSuperClass() was never used for these operations.

http://gwt-code-reviews.appspot.com/1312801/diff/3001/4004
File dev/core/src/com/google/gwt/dev/jjs/ast/JInterfaceType.java
(right):

http://gwt-code-reviews.appspot.com/1312801/diff/3001/4004#newcode36
dev/core/src/com/google/gwt/dev/jjs/ast/JInterfaceType.java:36: return
null;
Yep.  But because it *is* implicit and always true, there's no real need
to model this in the AST.

In practice, getSuperClass() is generally only ever used when you really
want to walk up a hierarchy of JClassTypes.

http://gwt-code-reviews.appspot.com/1312801/diff/3001/4012
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(right):

http://gwt-code-reviews.appspot.com/1312801/diff/3001/4012#newcode107
dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:107:
classType.getSuperClass(), dims);
Actually, you raise a good point.  I think I need to come back here and
make sure that (say), IFoo[][] rescues Object[][] (and Object[]).

I'll make sure I cover this case before I submit.

http://gwt-code-reviews.appspot.com/1312801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to